[PATCH v2 3/4] package: usbgadget: Fix subpackage dependencies
Chuanhong Guo
gch981213 at gmail.com
Thu Apr 3 18:51:03 PDT 2025
Hi!
On Thu, Apr 3, 2025 at 2:51 PM Linus Walleij <linus.walleij at linaro.org> wrote:
>
> Currently if a target wants to use acm or ncm gadget config,
> they need to select both usbgadget and the config package
> such as usbgadget-acm.
>
> It's better if the target just select usbgadget-acm and get
> all dependencies satisfied.
>
> Adding a dependency using usbgadget+ fixes this.
>
> Cc: Chuanhong Guo <gch981213 at gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> package/utils/usbgadget/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/utils/usbgadget/Makefile b/package/utils/usbgadget/Makefile
> index 55f30b6729a00c6cf28da19f25653a3217243495..40a68b7601a8b73770fc3fc921df6f708a143ffb 100644
> --- a/package/utils/usbgadget/Makefile
> +++ b/package/utils/usbgadget/Makefile
> @@ -54,5 +54,5 @@ define GadgetPreset
> $$(eval $$(call BuildPackage,$(PKG_NAME)-$(1)))
> endef
>
> -$(eval $(call GadgetPreset,ncm,CDC-NCM,+kmod-usb-gadget-ncm))
> -$(eval $(call GadgetPreset,acm,CDC-ACM,+kmod-usb-gadget-serial))
> +$(eval $(call GadgetPreset,ncm,CDC-NCM,+usbgadget +kmod-usb-gadget-ncm))
> +$(eval $(call GadgetPreset,acm,CDC-ACM,+usbgadget +kmod-usb-gadget-serial))
This dependency is needed by all preset packages and can be added to
the GadgetPreset template instead.
Other than that:
Reviewed-by: Chuanhong Guo <gch981213 at gmail.com>
--
Regards,
Chuanhong Guo
More information about the openwrt-devel
mailing list