Commit "mt76: update to Git HEAD (2024-09-29)" causing warning on missing dependency on kmod-mt7996

Felix Fietkau nbd at nbd.name
Sun Sep 29 11:04:28 PDT 2024


On 29.09.24 19:43, Bas Mevissen wrote:
> Hi,
> 
> The commit "mt76: update to Git HEAD (2024-09-29)"
> (2f7d22dc6fbb9532b82522c4a78434a07f9d8fb1) causes the following warning
> to be introduced:
> 
> 
>> WARNING: Makefile 'package/kernel/mt76/Makefile' has a dependency on 'kmod-mt7996', which does not exist
> 
> This is due to the following snippet:
> 
> 
> diff --git a/package/kernel/mt76/Makefile b/package/kernel/mt76/Makefile
> index 4d808c96b3..872dec0e76 100644
> --- a/package/kernel/mt76/Makefile
> +++ b/package/kernel/mt76/Makefile
> @@ -8,9 +8,9 @@ PKG_LICENSE_FILES:=
> 
>    PKG_SOURCE_URL:=https://github.com/openwrt/mt76
>    PKG_SOURCE_PROTO:=git
> -PKG_SOURCE_DATE:=2024-09-05
> -PKG_SOURCE_VERSION:=65cc3daf2a332cc658e9f7438cdadde4392e672e
> -PKG_MIRROR_HASH:=c29c4f883051a6360119156a03e010ac11573011b23d9e873f83c720600970e7
> +PKG_SOURCE_DATE:=2024-09-29
> +PKG_SOURCE_VERSION:=680bc70f161fde0f167e2ae50c771be4775eb50a
> +PKG_MIRROR_HASH:=bcdb95e40cfceba56a565ad6b6d9f92a122e7230d0f7f950b3d39e4280723cca
> 
>    PKG_MAINTAINER:=Felix Fietkau <nbd at nbd.name>
>    PKG_USE_NINJA:=0
> @@ -323,10 +323,34 @@ define KernelPackage/mt7996e
>      AUTOLOAD:=$(call AutoProbe,mt7996e)
>    endef
> 
> +define KernelPackage/mt7992-firmware
> +  $(KernelPackage/mt76-default)
> +  TITLE:=MediaTek MT7992 firmware
> +  DEPENDS+=+kmod-mt7996
> +endef
> 
> Shouldn't the second last line read "+  DEPENDS+=+kmod-mt7996e" instead?

You're right, I wonder why my build test didn't catch it.
Fixed now, thanks.

- Felix



More information about the openwrt-devel mailing list