[PATCH 2/2] treewide: remove INITRAMFS check for preinit_main hook

Elliott Mitchell ehem+undef at m5p.com
Thu Sep 26 13:40:40 PDT 2024


On Thu, Sep 26, 2024 at 08:14:45AM +0200, Florian Eckert wrote:
> 
> Any progress on this Subject?
> Maybe you missed it, but I have sent a reworked patch [1].

> [1] https://patchwork.ozlabs.org/project/openwrt/patch/20240910141839.3433214-1-fe@dev.tdt.de/

Sorry, missed this; alas I do tend to drop things.  Note, I am a
community reviewer and so cannot bring anything into OpenWRT's tree
myself.

I like this approach far better.  Problem is you've missed a number of
scripts which are effected by the change.  Of note:

package/base-files/files/lib/preinit/99_10_failsafe_login
package/system/urandom-seed/files/lib/preinit/81_urandom_seed

You can place a note under the "---" after the "Signed-off-by" line.
This can be used for statements such as those two were examined and
aren't effected by the change.  There are also a bunch of other files
which may interact:

find target/linux -name preinit -print | while read d
do	find "$d" -mindepth 1 -name \[7-~\]\* -print
done


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445





More information about the openwrt-devel mailing list