[PATCH] realtek: add missing PHY handles for GS1900-10HP

[Bjørn Mork]

Stijn Segers <foss at volatilesystems.org> writes:

> So what do you suggest? Leave it as-is?

Either that or remove the bogus error message from the driver.  This is
not an error.

If any cleanup should be done in the GS1900-10HP dts, then removing
those two bogus internal phys would be the correct thing to do.

> I can't recall seeing this
> error with 5.15.

It was there for me:


[    0.000000] Linux version 5.15.158 (bjorn at canardo) (mips-openwrt-linux-musl-gcc (OpenWrt GCC 13.2.0 r26302-4f87a4d84f3d) 13.2.0, GNU ld (GNU Binutils) 2.42) #0 Mon May 13 08:15:17 2024
[    0.000000] RTL838X model is 83806800
[    0.000000] SoC Type: RTL8380
[    0.000000] printk: bootconsole [early0] enabled
[    0.000000] CPU0 revision is: 00019070 (MIPS 4KEc)
[    0.000000] MIPS: machine is ZyXEL GS1900-10HP Switch
[    0.000000] earlycon: ns16550a0 at MMIO 0x18002000 (options '115200n8')
[    0.000000] printk: bootconsole [ns16550a0] enabled
...

[    3.885337] Realtek RTL8218B (internal) rtl838x slave mii-0:08: Detected internal RTL8218B
[    3.894752] Firmware loaded. Size 1184, magic: 83808380
[    4.199898] sfp sfp-p9: module OEM              GLC-T            rev B    sn M0312A804        dc 130823  
[    4.310319] sfp sfp-p10: module Tsuhan           THMPRS-3511-10A  rev A    sn F19021506991     dc 190409  
[    6.713738] Realtek RTL8380 SERDES rtl838x slave mii-0:18: Detected internal RTL8380 SERDES
[    6.723249] Firmware loaded. Size 1184, magic: 83808380
[    6.729162] SDS power down value: 3
[    6.757270] PLL control register: f
[    6.761319] SDS power down value now: 3f
[    6.765729] Configuration of SERDES done
[    6.797530] rtl83xx-switch switch at 1b000000: Port node 24 misses phy-handle
[    6.805417] rtl83xx-switch switch at 1b000000: Port node 26 misses phy-handle
[    6.817852] In rtl83xx_vlan_setup



Bjørn