[PATCH] realtek: add missing PHY handles for GS1900-10HP

Bjørn Mork bjorn at mork.no
Sun Sep 22 09:29:50 PDT 2024


Stijn Segers <foss at volatilesystems.org> writes:

> Fixes the following error in dmesg:
>
>   [    7.703678] rtl83xx-switch switch at 1b000000: Port node 24 misses phy-handle
>   [    7.711556] rtl83xx-switch switch at 1b000000: Port node 26 misses phy-handle

rtl83xx_mdio_probe() is weird.  I guess the SoC phy polling makes that
necessary. But it should accept sfp ports without phys, because that's
what these are.  There are pnly 8 internal phys in this switch.

> @@ -59,6 +59,7 @@
>  		port at 24 {
>  			reg = <24>;
>  			label = "lan9";
> +			phy-handle = "<&phy24>";
>  			phy-mode = "1000base-x";
>  			managed = "in-band-status";
>  			sfp = <&sfp0>;

This does not describe any hardware.  It just works around a driver bug.


Bjørn



More information about the openwrt-devel mailing list