[RFC PATCH 11/14] config: clamp ra_retranstime
Paul Donald
newtwen+github at gmail.com
Thu May 9 15:30:43 PDT 2024
From: Paul Donald <newtwen at gmail.com>
Attempt to be helpful.
Signed-off-by: Paul Donald <newtwen at gmail.com>
---
src/config.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/config.c b/src/config.c
index e0f2d80..160d7db 100644
--- a/src/config.c
+++ b/src/config.c
@@ -951,11 +951,10 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
if ((c = tb[IFACE_ATTR_RA_RETRANSTIME])) {
uint32_t ra_retranstime = blobmsg_get_u32(c);
- if (ra_retranstime <= 60000)
- iface->ra_retranstime = ra_retranstime;
- else
- syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
- iface_attrs[IFACE_ATTR_RA_RETRANSTIME].name, iface->name);
+ iface->ra_retranstime = (ra_retranstime <= 60000) ? ra_retranstime : 60000;
+ if (ra_retranstime > 60000)
+ syslog(LOG_INFO, "Clamped invalid %s value configured for interface '%s' to %d",
+ iface_attrs[IFACE_ATTR_RA_RETRANSTIME].name, iface->name, iface->ra_retranstime);
}
if ((c = tb[IFACE_ATTR_RA_HOPLIMIT])) {
--
2.44.0
More information about the openwrt-devel
mailing list