[PATCH 2/2] realtek: add RTL821X_CHIP_ID

[Bjørn Mork]

Stijn Tintel <stijn at linux-ipv6.be> writes:

> On 27/04/2024 11:16, Bjørn Mork wrote:
>> stijn at linux-ipv6.be writes:
>>
>>>   	phy_write_paged(phydev, 31, 27, 0x0002);
>>>   	val = phy_read_paged(phydev, 31, 28);
>> ..
>>>   	phy_write_paged(phydev, 0x1f, 0x1b, 0x0002);
>>>   	val = phy_read_paged(phydev, 0x1f, 0x1c);
>>
>> While you're doing spring cleaning....  That piece of cut-n-paste code
>> looks very funny.
>>
> I'd gladly do some more spring cleaning, but what's your actual
> suggestion here? Use hex everywhere instead of mixed hex/base 10?

I would have used hex since that 0x1f looks like a mask.

But it should at least be consistent so that it is obvious that this
code is a target for de-duplication.


Bjørn