[PATCH] kernel: kmod-phy-smsc: add dependency on crc16

[Elliott Mitchell]

On Fri, Mar 29, 2024 at 09:57:04AM +0100, Robert Marko wrote:
> On Thu, 28 Mar 2024 at 18:03, Tomasz Maciej Nowak <tmn505 at terefe.re> wrote:
> >
> > From: Tomasz Maciej Nowak <tmn505 at gmail.com>
> >
> > Introduced WoL feature needs CRC16 support.
> >
> > Signed-off-by: Tomasz Maciej Nowak <tmn505 at gmail.com>
> > ---
> >  package/kernel/linux/modules/netdevices.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/kernel/linux/modules/netdevices.mk b/package/kernel/linux/modules/netdevices.mk
> > index af1d8b485e00..724f35df74a2 100644
> > --- a/package/kernel/linux/modules/netdevices.mk
> > +++ b/package/kernel/linux/modules/netdevices.mk
> > @@ -363,7 +363,7 @@ define KernelPackage/phy-smsc
> >     SUBMENU:=$(NETWORK_DEVICES_MENU)
> >     TITLE:=SMSC PHY driver
> >     KCONFIG:=CONFIG_SMSC_PHY
> > -   DEPENDS:=+kmod-libphy
> > +   DEPENDS:=+kmod-libphy +!LINUX_5_15||!LINUX_6_1:kmod-lib-crc16

> I would prefer depending on 6.6 for the kmod, not the other way around.

I am *very* strongly of the opposite opinion.  Issue is detecting 5.15
and 6.1 is a stable state.  At a future point when 6.10/6.11.6.12/7.0/7.1
are added, no additional maintenance is required if 5.15 and 6.1 are
detected.  Whereas if 6.6 is detected, this *must* be adjusted when the
next kernel version shows up.

The one advantage is by *forcing* maintenance sooner, the construct is
likely to be removed sooner.  Ultimately turns into an issue of which is
more concerning, having this hang around longer, versus making this an
urgent issue in the near future.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445