[PATCH] base-files: sysupgrade: include uci-defaults script disabling services

[Rafał Miłecki]

On 15.02.2024 18:46, Paul D wrote:
> On 2024-02-15 15:42, Rafał Miłecki wrote:
>> On 14.02.2024 21:50, Paul D wrote:
>>> Would services not do better to be tracked within uci and its config files in /etc/config?
>>
>> Well, it's a part of a mess we have in our init/config code. It was only
>> last week that Jo was discussing it with Ansuel. In short we have:
>> 1. Packages with no UCI config option for enabling/disabling
>> 2. Packages with "enable"
>> 3. Packages with "enabled"
>> 4. Packages with "disable"
>> 5. Packages with "disabled"
>>
>> I'm pretty sure most users are used to enabling/disabling services
>> using UCI config option but not all of them have such possibility. That
>> is the case my change is meant to deal with.
>>
>> An alternative would be to make sure every package uses "enabled" (or
>> "disabled") UCI option. Should we do that?
>>
> 
> Is 'on' or 'off' in the config perhaps simpler? I think it avoids the linguistic differences of past participle vs present simple. (Sometimes this distinction is important to have.)
> 
> Otherwise 'en/disabled' is a good paradigm to encourage in configs.

Do you mean "on" and "off" as option values? How would you call such option? "enabled"? :P Something like "status" would be misleading again.

Or if you mean "on" and "off" as option names then what value should we assign?
uci set foo.config.on=1
?

No, I don't think "on" / "off" is a good option at all.