[PATCH] base-files: sysupgrade: include uci-defaults script disabling services

[Eric]

On Thursday, February 15th, 2024 at 06:42, Rafał Miłecki <zajec5 at gmail.com> wrote:
> I'm pretty sure most users are used to enabling/disabling services
> using UCI config option but not all of them have such possibility. That
> is the case my change is meant to deal with.

Well, there was some user discussion on the forum a couple months back and
I've always felt 'service X enable/disable' was the right way to do things.
https://forum.openwrt.org/t/bug-service-status-is-not-saved-after-sysupgrade/179045

> An alternative would be to make sure every package uses "enabled" (or
> "disabled") UCI option. Should we do that?

I recently reworked the snort3 package and added "enabled" to its config.
I felt then (and still do) that this is sort of a "hack around a bug",
and would rather see it addressed as part of sysupgrade's backup/restore
process.

I'm a definite +1 on your current patch for sysupgrade, it looks like 
an elegant, unintrusive and robust means for dealing with service state.

Eric