[PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

Elliott Mitchell ehem+openwrt at m5p.com
Fri Nov 17 13:31:50 PST 2023


On Fri, Nov 17, 2023 at 05:20:33PM +0100, Felix Fietkau wrote:
> On 11.11.23 01:21, Elliott Mitchell wrote:
> > This removes the requirement for to create a package for all modules.
> > Now devices can simply specify in-tree drivers/other to be built as
> > modules and they will be present in the resultant image.
> > 
> > Signed-off-by: Elliott Mitchell <ehem+openwrt at m5p.com>
> 
> It seems to me that this completely ignores the use case of having 
> release builds that ship a lot of kernel modules as installable 
> packages. Did I misread something?
> If not, this gets a strong NACK from me.

Should be completely orthogonal, though it could have bugs.

Using `cp -l` has two valuable effects:  First, it reduces storage space
usage.  Second, it serves to mark module files as belonging to a package.

My goal is previously setting a kernel option to "m" in a configuration
file, but not having a package causes it to be built, then ignored.  I
want this to do something sensible, not simply waste electricity
building a module and then tossing it in the garbage.

Hmm, come to think of it, that should be $(XARGS) (fix on commit?).


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445





More information about the openwrt-devel mailing list