[PATCH 2/8] ipq806x: Point to externally compiled dtbs in recipes

Brian Norris computersforpeace at gmail.com
Wed Jan 4 18:29:34 PST 2023


On Wed, Jan 04, 2023 at 01:50:17PM +0100, Christian Marangi wrote:
> On Mon, Jan 02, 2023 at 03:25:28PM -0800, Brian Norris wrote:
> > See also:
> > 
> > commit 4d8b42d8a7774070ac0439915f8de1430db9a8e3
> > Author: Tomasz Maciej Nowak <tmn505 at gmail.com>
> > Date:   Thu Aug 25 20:26:11 2022 +0200
> > 
> >     ipq40xx: point to externally compiled dtbs in recipes
> > 
> >     Adjusting dts will cause a rebuild of whole kernel as the buildroot
> >     considers this a part of kernel source. It's a royal PITA when trying to
> >     prepare support for new device, since this takes a lot of time on slower
> >     systems. As it stands, buildroot itself, with own rule, also compiles
> >     dtbs and the results are $(KDIR)/image-$(DEVICE_DTS).dtb. With setting
> >     DEVICE_DTS_DIR to directory holding the device dts (similarly to some
> >     other targets), buildroot doesn't consider changed dts as part of kernel
> >     source and rebuilds only dtb. This really speeds up development. And
> >     since the kernel built dts are no longer used, drop the paches adding
> >     dtses to its build.
> > 
> > In a similar fashion, we can drop the DTS patch.
> 
> Can we improve the commit description without appending the commit
> description of another commit? Seems wrong to me.

Sure. I suppose I can liberally borrow (and reference) the description
instead of quoting.

> If you already found a similar commit description feel free to link as I
> could be totally wrong about this.

Eh, my quick search didn't really find any. The closest was something
like this:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=0dc58214896aacf67a3759495d70e2b4e9c160d8
where at least some of the larger metadata (author, commiter, dates)
were pasted.

Brian



More information about the openwrt-devel mailing list