[PATCH] ramips: use ARTIFACTS for initramfs-factory of I-O DATA WN-AX1167GR

[Daniel Golle]

On Tue, Nov 29, 2022 at 09:30:25PM +0900, INAGAKI Hiroshi wrote:
> Hi Daniel,
> 
> thank you for your review.
> 
> On 2022/11/29 11:07, Daniel Golle wrote:
> > On Wed, Nov 23, 2022 at 12:24:09PM +0900, INAGAKI Hiroshi wrote:
> ...
> > > @@ -972,10 +955,13 @@ define Device/iodata_wn-ax1167gr
> > >     $(Device/dsa-migration)
> > >     $(Device/uimage-lzma-loader)
> > >     IMAGE_SIZE := 15552k
> > > -  KERNEL_INITRAMFS := $$(KERNEL) | \
> > > -	iodata-factory 7864320 4 0x1055 $(KDIR)/tmp/$$(KERNEL_INITRAMFS_PREFIX)-factory.bin
> > >     DEVICE_VENDOR := I-O DATA
> > >     DEVICE_MODEL := WN-AX1167GR
> > > +ifneq ($(CONFIG_TARGET_ROOTFS_INITRAMFS),)
> > > +  ARTIFACTS := initramfs-factory.bin
> > > +  ARTIFACT/initramfs-factory.bin := append-image initramfs-kernel.bin | \
> > Please use 'append-image-stage' so this will work also with the
> > ImageBuilder where initramfs is not being generated/present.
> 
> Oh, I didn't know it. Then, should I remove ifneq-endif switch for IB?

Yes, you should also drop the ifneq-endif for IB.

> 
> > 
> > > +	check-size 7680k | senao-header -r 0x30a -p 0x1055 -t 4
> > > +endif
> > >     DEVICE_PACKAGES := kmod-mt7603 kmod-mt76x2
> > >   endef
> > >   TARGET_DEVICES += iodata_wn-ax1167gr
> > > -- 
> > > 2.36.1.windows.1
> > > 
> > > 
> > > _______________________________________________
> > > openwrt-devel mailing list
> > > openwrt-devel at lists.openwrt.org
> > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel