[PATCH 2/6] add device setting for disabeling arp

Joerg Vehlow lkml at jv-coder.de
Fri Nov 4 01:07:36 PDT 2022


Hi Oldrich,

Am 11/4/2022 um 8:54 AM schrieb Oldřich Jedlička:
>> diff --git a/system-linux.c b/system-linux.c
>> index 6232a26..7b82e17 100644
>> --- a/system-linux.c
>> +++ b/system-linux.c
>> @@ -1736,6 +1736,9 @@ system_if_get_settings(struct device *dev, struct device_settings *s)
>>
>>                 s->multicast = ifr.ifr_flags & IFF_MULTICAST;
>>                 s->flags |= DEV_OPT_MULTICAST;
>> +
>> +               s->arp = !(ifr.ifr_flags & IFF_NOARP);
>> +               s->arp |= DEV_OPT_ARP;
> 
> I am just a random reader, but this looks like a bug – shouldn't
> DEV_OPT_ARP be applied to s->flags and not to s->arp?
> 
> Oldrich.

Good catch, thanks!

Joerg



More information about the openwrt-devel mailing list