[PATCH] realtek: don't unmask non-maskable GPIO IRQs

Sander Vanheule sander at svanheule.net
Sun May 29 22:27:03 PDT 2022


On Sun, 2022-05-29 at 23:22 +0200, Robert Marko wrote:
> On Sun, 29 May 2022 at 19:49, Sander Vanheule <sander at svanheule.net> wrote:
> > 
> > On uniprocessor builds, for_each_cpu(cpu, mask) will assume 'mask'
> > always contains exactly one CPU, and ignore the actual mask contents.
> > This causes the loop to run, even when it shouldn't on an empty mask,
> > and tries to access an unintialised pointer.
> > 
> > Fix this by wrapping the loop in a cpumask_empty() check, to ensure it
> > will not run on uniprocessor builds if the CPU mask is empty.
> > 
> > Fixes: af6cd37f42f3 ("realtek: replace RTL93xx GPIO patches")
> > Reported-by: Robert Marko <robimarko at gmail.com>
> > Reported-by: INAGAKI Hiroshi <musashino.open at gmail.com>
> > Signed-off-by: Sander Vanheule <sander at svanheule.net>
> 
> Works on DGS-1210-28P, so:
> Tested-by: Robert Marko <robimarko at gmail.com>

Thanks for giving it a spin as well! I've merged the patch into master, after fixing a whitespace
issue and typo in the commit message.

Best,
Sander



More information about the openwrt-devel mailing list