[PATCH v2] bcm53xx: complete Asus RT-AC88U support

[Arınç ÜNAL]

On 03/05/2022 11:24, Rafał Miłecki wrote:
> On 31.03.2022 08:35, Arınç ÜNAL wrote:
>> Add white:lan LED configuration. Remove the BROKEN flag.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal at arinc9.com>
>> ---
>> v2: remove adding rtl8365mb patch as it's already done.
>>
>> ---
>>   target/linux/bcm53xx/base-files/etc/board.d/01_leds | 3 +++
>>   target/linux/bcm53xx/image/Makefile                 | 1 -
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/target/linux/bcm53xx/base-files/etc/board.d/01_leds 
>> b/target/linux/bcm53xx/base-files/etc/board.d/01_leds
>> index aba526b9c3..bd24234046 100644
>> --- a/target/linux/bcm53xx/base-files/etc/board.d/01_leds
>> +++ b/target/linux/bcm53xx/base-files/etc/board.d/01_leds
>> @@ -4,6 +4,9 @@
>>   board_config_update
>>   case "$(board_name)" in
>> +asus,rt-ac88u)
>> +    ucidef_set_led_netdev "lan" "LAN" "white:lan" "eth1"
>> +    ;;
> 
> I believe this router uses
> WAN LED for WAN traffic (1 port)
> LAN LED for LAN traffic (8 ports)
> 
> If you use eth1 interface as LED trigger, won't it make LAN LED react
> also to WAN traffic?
> 
> My guess: should we assign 8 switch ports as that LED triggers?

There's red and white LEDs for WAN but the white one is actually not 
wired to any GPIO. Official Asus firmware controls it some other way. So 
we could only use the red one for wan traffic which I don't like. On top 
of that, we'd have to listen a bridge interface (we can't define 
multiple interfaces) in order to cover traffic on all of the lan ports 
of the switch which I also don't like because the configuration can be 
changed by user.

I think we should leave this to the user. You can discard the LED 
configuration and just remove the BROKEN flag.

Arınç