[PATCH V3] ipq40xx: fix BDF file for pcie wifi chip on the GL.Inet GL-B2200

[Christian Lamparter]

On Thu, Apr 28, 2022 at 10:42 AM Robert Marko <robimarko at gmail.com> wrote:
>
> On Thu, 28 Apr 2022 at 08:57, Enrico Mioso <mrkiko.rs at gmail.com> wrote:
> >
> > After the switch to pre-calibration, ath10k would fail to initialize
> > the PCIE Wi-Fi on the GL-B200 as follows:
> >
> > ath10k_pci 0000:01:00.0: enabling device (0140 -> 0142)
> > ath10k_pci 0000:01:00.0: qca9888 hw2.0 target 0x01000000 chip_id 0x00000000 sub 0000:0000
> > [...]
> > ath10k_pci 0000:01:00.0: failed to fetch board data for bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=GL-B2200 from ath10k/QCA9888/hw2.0/board-2.bin
> > ath10k_pci 0000:01:00.0: failed to fetch board-2.bin or board.bin from ath10k/QCA9888/hw2.0
> > ath10k_pci 0000:01:00.0: failed to fetch board file: -12
> > ath10k_pci 0000:01:00.0: could not probe fw (-12)
> >
> > Repackage the BDF file after renaming relevant fields and files to
> > allow for the Wi-Fi interface to start again.
> >
> > Fixes: 80d34d9d593 ("ipq40xx: document pcie wifi chip on the GL.Inet GL-B2200")
> > CC: Christian Lamparter <chunkeey at gmail.com>
> > CC: Robert Marko <robimarko at gmail.com>
> > Signed-off-by: Enrico Mioso <mrkiko.rs at gmail.com>
>
> LGTM,
> Reviewed-by: Robert Marko <robert.marko at sartura.hr>

I'll definitively second that too. It's good.

It would be perfect if the QCA9888 board.bin version could also be
submitted to ath10k Mailing-List:
<https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles>
so it will eventually go into linux-firmware.git's QCA9888's board-2.bin.

Yes, this should have already happened when the board was added. Maybe
the mismatched identification string would have been caught right there...

Previous submissions can be used as a template:
<https://lore.kernel.org/all/87czklb324.fsf@kernel.org/T/> (i.e:
QCA9888 hw2.0: Add EnGenius EAP2200 )

Cheers,
Christian