[PATCH 1/2] realtek: Use firewall4

[Sander Vanheule]

On Tue, 2022-03-01 at 09:09 +0100, Petr Štetiar wrote:
> Sander Vanheule <sander at svanheule.net> [2022-02-28 23:00:34]:
> 
> Hi,
> 
> > Commit 9e7149f729e9 ("realtek: revert to "standard" management configuration") changed
> > the
> > default port configuration for realtek devices to only have LAN ports, instead of the
> > LAN/WAN VLANs that were used before.
> 
> IMO default device configuration and default OS feature set are two different topics.
> 
> > I wonder if it doesn't make more sense to drop the firewall package from the
> > default now, since there is only one interface, unless there is a different
> > reason to keep the firewall.
> 
> 1. consistency
> 2. supporting more common use cases out of the box
> 3. wider testing audience of core networking components

These are valid arguments, but to me rather arguments to move the firewall from
DEFAULT_PACKAGES.router to DEFAULT_PACAKGES. That way they wouldn't have to be added
separately on non-router devices. OpenWrt devices with DEVICE_TYPE=nas also don't come
with a firewall by default AFAICT. I think if you feel the firewall should be included by
default on a switch with only lan-facing ports, it would certainly make sense to include
it on a NAS too.

Best,
Sander