[PATCH] command-nas: fix cmd_nas_get_cell_location_info_cb

Jan-Niklas Burfeind git at aiyionpri.me
Mon Mar 7 02:53:03 PST 2022


Hello Cezary,
I think for that particular problem it wuld suffice to wrap the three 
cell-objects in an array called cells.
I drafted a commit for this, but am currently sitting in a train and can 
only test it in a few hours.

Looking at the surrounding code there appear to be more for-loops, that 
might produce similar problems.
Without breaking existing codes, it might be worthwile to ask the 
original author about his intention  on this.

Until later
Aiyion

On 3/6/22 18:37, Cezary Jackiewicz wrote:
> Dnia 2022-03-06, o godz. 18:25:57
> Jan-Niklas Burfeind <git at aiyionpri.me> napisał(a):
> 
>> Correct order of rsrp and rsrq parameters for print_lte_info.
>>
>> Signed-off-by: Jan-Niklas Burfeind <git at aiyionpri.me>
> 
> Hi,
> BTW, syntax is invalid. Output is not valid json format.
> Could you also proper format output?
> 
> Ex: missing keys after serving_cell_id:
> 
> # uqmi -d /dev/cdc-wdm0 --get-cell-location-info
> {
> 	"intrafrequency_lte_info": {
> 		"tracking_area_code": 11041,
> 		"global_cell_id": 2742796,
> 		"channel": 3526,
> 		"band": 8,
> 		"frequency": 900,
> 		"duplex": "FDD",
> 		"serving_cell_id": 49,
> 		{
> 			"physical_cell_id": 49,
> 			"rsrq": -70.800000,
> 			"rsrp": -10.400000,
> 			"rssi": -47.200000
> 		},
> 		{
> 			"physical_cell_id": 10,
> 			"rsrq": -78.500000,
> 			"rsrp": -17.900000,
> 			"rssi": -50.900000
> 		},
> 		{
> 			"physical_cell_id": 50,
> 			"rsrq": -78.400000,
> 			"rsrp": -18.500000,
> 			"rssi": -50.900000
> 		}
> 	}
> }
> 
> 



More information about the openwrt-devel mailing list