[PATCH v2 1/2] ath79: add support for reset key on MikroTik RB912UAG-2HPnD

Sergey Ryazanov ryazanov.s.a at gmail.com
Tue Jan 18 14:28:24 PST 2022


On Mon, Jan 17, 2022 at 11:52 AM Denis K <denis281089 at gmail.com> wrote:
>> I'm seeing this in the bootlogs when using this patch:
>>
>> [    5.183305] gpio-latch gpio_latch: failed to get gpio 7: -517
>> [    5.235889] rb91x-nand nand_gpio: failed to get gpios: -517
>
> It's okay. The gpio-latch probe function seems to be called before the
> rb91x-key probe, but it also returns  EPROBE_DEFER (-517), so it will
> be called later.

Nice catch!

Will it be a good idea to avoid printing the error messages from the
gpio-latch/rb91x-nand drivers in case of EPROBE_DEFER? Looks like this
will help to avoid noise in the dmesg and users confusion.

I do not mean doing this immediately in this series, but maybe
somedays this will be a welcome change?

-- 
Sergey



More information about the openwrt-devel mailing list