[PATCH v2] realtek: don't set L2LEARNING flag in rtl83xx TX header

Sander Vanheule sander at svanheule.net
Tue Dec 27 07:48:08 PST 2022


On Sat, 2022-12-17 at 21:39 +0100, Jan Hoffmann wrote:
> As learning for the CPU port is now disabled globally, the bit in the
> TX header doesn't have any effect anymore. Remove it to make the header
> consistent with the global configuration.
> 
> Originally, this change was intended to be applied before commit
> eb456aedfe24 ("realtek: use assisted learning on CPU port"), which is
> why the commit message incorrectly mentions that the TX header already
> disables learning.
> 
> The reason for disabling learning on the CPU port in the first place is
> that it doesn't work correctly when packets are trapped to the CPU and
> then forwarded by the CPU to other ports. In that case, the switch would
> incorrectly learn the CPU port as source. An example that triggered this
> issue are Multicast Listener Reports and IGMP membership reports.
> 
> Signed-off-by: Jan Hoffmann <jan at 3e8.eu>

Thanks! Merged to master.

Best,
Sander




More information about the openwrt-devel mailing list