[PATCH v3] realtek: ensure output drivers are enabled in RTL8231

Paul Fertser fercerpav at gmail.com
Sat Oct 2 09:51:27 PDT 2021

Hello Adrian,

Thank you for taking care about this. One note below.

On Sat, Oct 02, 2021 at 06:37:22PM +0200, Adrian Schmutzler wrote:
> > The bootloader can leave the GPIO expander in a state which doesn't have
> > output drivers enabled so GPIOs will properly work for input but output
> > operations will have no effect.
> > Reviewed-by: Sander Vanheule <sander at svanheule.net>
> > Signed-off-by: Paul Fertser <fercerpav at gmail.com>
> I added
> Fixes: 16ae56b4f9ec ("realtek: fix RTL8231 gpio expander for high GPIOs")

Even though the patch changes the code that was introduced before with
the patch you mention it's not fixing it. Commit 16ae56b4f9ec was
fixing another bug (working with high GPIOs) and it was consistent
with the existing code (that wasn't changing input/output state on
init). However, that clearly leads to GPIOs not being able to work for
output at least on some of the supported targets so if anything it
should have

Fixes: 2b88563ee5aa ("realtek: update the tree to the latest refactored version")

Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav at gmail.com

More information about the openwrt-devel mailing list