[PATCH v2] realtek: sort the port list numerically
hauke at hauke-m.de
Mon Nov 29 13:31:24 PST 2021
On 11/29/21 2:18 PM, Bjørn Mork wrote:
> Mac adresses are assigned in the order given by the port list. The
> interfaces are also brought up in this order. This target supports
> devices with up to 52 ports. Sorting these alphabetically is very
> confusing, and assigning mac addresses in alphabetic order does not
> match stock firmware behaviour.
> Suggested-by: Sander Vanheule <sander at svanheule.net>
> Signed-off-by: Bjørn Mork <bjorn at mork.no>
> Hauke Mehrtens <hauke at hauke-m.de> writes:
>> I applied the first and the last patch, could you please resend the
>> reworked patch "realtek: sort the port list numerically ".
> Thanks! Crossing fingers that this won't break too much for those who
> have gotten used to the odd defaults...
I hope so too. I do not know how many users the realtek target already
has, but new users will probably be happy that they do not have to use a
specific port and VLAN 100.
> Here's a new version of the remaining patch, using Sander's much nicer
> implementation. I did a quick "sysupgrade -n" test on my GS108Tv3 and
> it seems to work. Although that one has too few ports for this to
> really make any difference...
Could someone with a switch with more ports please test this and report
back. My switch only has 8 ports.
More information about the openwrt-devel