[PATCH v2 1/2] ath79: add support for reset key on MikroTik RB912UAG-2HPnD

Sergey Ryazanov ryazanov.s.a at gmail.com
Tue Nov 16 15:42:15 PST 2021

On Tue, Nov 16, 2021 at 7:07 PM Denis Kalashnikov <denis281089 at gmail.com> wrote:
> On MikroTik RB91x board series a reset key shares SoC gpio
> line #15 with NAND ALE and NAND IO7. So we need a custom
> gpio driver to manage this non-trivial connection schema.
> Also rb91x-nand needs to have ability to disable a polling
> of the key while it works with NAND, and we need to add
> "cansleep" suffix to several gpiolib calls in gpio-latch.
> Signed-off-by: Denis Kalashnikov <denis281089 at gmail.com>

Please find below one nonsignificant nitpick, in all other respects:

Reviewed-by: Sergey Ryazanov <ryazanov.s.a at gmail.com>

> +struct gpio_rb91x_key {
> +       struct gpio_chip gc;
> +       struct mutex mutex;
> +       struct mutex poll_mutex;

These mutexes are worth a line of documentation. I do not care too
much, but if by some other reason you will submit v3, please consider
to describe their purpose.

> +       int polling_disabled;
> +       struct gpio_desc *gpio;
> +};

More information about the openwrt-devel mailing list