[PATCH 2/3] realtek: enable gpio-restart driver in target

Sander Vanheule sander at svanheule.net
Fri Nov 12 13:15:10 PST 2021


On Sun, 2021-10-03 at 15:53 +0900, INAGAKI Hiroshi wrote:
> On Panasonic Switch-M8eG PN28080K, a GPIO pin on PCA9539 chip is used
> for for hard-reset of the system. To use this, enable gpio-restart
> driver and built-in to the kernel.
> Signed-off-by: INAGAKI Hiroshi <musashino.open at gmail.com>

As made clear by Paul Fertser, gpio-restart isn't actually used unless _machine_restart()
is also removed. Although I don't mind adding the correct nodes to the DTS already (maybe
others disagree). Adding the driver already would only have the effect (benefit?) of
grabbing the relevant GPIO, and preventing users from using it accidentally.

I definitely think this driver should definitely be enabled, but do we wait with enabling
it until we can remove _machine_restart? Or can this already be merged as some sort of
preparatory patch?


More information about the openwrt-devel mailing list