[PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

Thibaut hacks at slashdirt.org
Wed Nov 10 02:20:53 PST 2021

> Le 10 nov. 2021 à 10:48, Robert Marko <robimarko at gmail.com> a écrit :
> On Wed, 10 Nov 2021 at 10:45, Denis K <denis281089 at gmail.com> wrote:
>>> Hi, wouldn't it be better for the rb_hardconfig_init to return
>>> -EPROBE_DEFER so the
>>> the core can try probing later?
>> Hello, Robert! I've tried what you suggested (return -EPROBE_DEFER
>> from rb_hardconfig_init and routerboot_init). It doesn't work.
>> do_one_initcall() from linux-5.4.158/init/main.c calls module init
>> function and it doesn't check return code and recall it later.
> Ahh, yeah since it's not a platform driver.
> Ideally, it should be converted to one so it has a probe method, and
> then deferring will work.
> Adding Thibaut as he is the original author,

Thanks, I don’t follow openwrt-devel.

> maybe there is a reason
> why the platform driver approach won't work.

Quite simply because there is no platform device to probe() for.

Can I get a full boot log (dmesg output) with the problem? It seems none was provided with the original patch here[1]
I’m not sure I can make sense of this: because the driver depends on SPI routines, it should be linked and loaded after SPI. This was the case so far.


[1] https://patchwork.ozlabs.org/project/openwrt/patch/20211109144607.7571-3-denis281089@gmail.com/

More information about the openwrt-devel mailing list