[PATCH 1/5] realtek: Consolidate bootargs

Sander Vanheule sander at svanheule.net
Thu Nov 4 09:57:17 PDT 2021

Hi Christian,

On Thu, 2021-11-04 at 17:07 +0100, Christian Lamparter wrote:
> On 04/11/2021 15:55, Sander Vanheule wrote:
> > All current devices use identical bootargs, so let's move that to the
> > common devicetree includes.
> hmm,  that "console=ttyS0,..." is fine. But there is a "DT-way" of doing
> it with stdout-path as per the documentation:
> https://www.kernel.org/doc/Documentation/devicetree/bindings/chosen.txt

For the upstream devicetrees we actually have the following:

    chosen {
        stdout-path = "serial0";
        bootargs = "earlycon console=ttyS0,115200";

I can update /chosen to be the same here.

> (Ideally this node or bootargs should be added by the bootloader/uboot
> so they stay in sync.)

I'm not entirely sure, but I don't think their bootloaders do this. At least on the
XGS1250-12, which is one of the most recent devices, I can't find anything. Certainly
the u-boot variables don't have any values set for bootargs.


More information about the openwrt-devel mailing list