Can I please request a review for an open PR?
josef.schlehofer at nic.cz
Wed May 19 01:42:06 PDT 2021
While we are at the packages repository , where are currently more
than 80 PR's opened, can someone take a look also at more than 200 PR's
opened at OpenWrt repository ? ;-) E.g. this PR -
Rather, my question is that anyone, even you, can review anything, share
your comments/thoughts and afterward review these changes and approve
them if you like them, of course.
If you take a look at the patch, not all of my comments were resolved,
unfortunately. In my opinion, we can not add patches where is no header
like author and more proper commit description. Ideally, all these
patches should be submitted to the upstream first, so we have few
unmaintained patches and less diversity against upstream projects. We
are constantly improving the packages repository and make it better for
In any case, I am not the only reviewer in the packages repository,
though. It is based on priorities, though. From my point, it looks
different when the reviewer or maintainer disappears as he/she is not
active at GitHub at all based on the activity.
On 19. 05. 21 10:08, Jaime wrote:
> I'm following an open PR
> (https://github.com/openwrt/packages/pull/15369) that is currently
> waiting on a review, but the reviewer has disappeared for a few weeks.
> Is it possible to request a review from another developer/committer?
> Thank you.
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 665 bytes
Desc: OpenPGP digital signature
More information about the openwrt-devel