[PATCH v3 1/2] imagebuilder: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archive
devel-sven at geroedel.de
Thu May 6 20:40:32 BST 2021
Am Donnerstag, 6. Mai 2021, 13:13:46 CEST schrieb Baptiste Jonglez:
> > + $(SED) 's/^CONFIG_BINARY_FOLDER=.*/# CONFIG_BINARY_FOLDER was reset by
> > Imagebuilder/' $(PKG_BUILD_DIR)/.config + $(SED)
> > 's/^CONFIG_DOWNLOAD_FOLDER=.*/# CONFIG_DOWNLOAD_FOLDER was reset by
> > Imagebuilder/' $(PKG_BUILD_DIR)/.config
> Several scripts assume that this exact format is used for disabled config:
> "# CONFIG_FOO is not set" (same as in the kernel).
> While your patch works [probably because these scripts are not run when
> using the ImageBuilder], it seems cleaner to stick to the standard format,
> e.g. in case a .config file is copied around from an imagebuilder.
The intention to not use th normal "unset" message was to leave a pointer why
it's unset in contrast to the build-time file, in case someone relies on it.
But I'm happy to us the normal message here.
More information about the openwrt-devel