[PATCH] fstools: block: fix segfault on mount with no target

Daniel Danzberger daniel at dd-wrt.com
Tue May 4 14:23:11 BST 2021


When a UCI fstab mount config doesn't contain a target option,
a 'block mount' call segfaults when comparing a mount's target (NULL)
to a found mount point returned by find_mount_point()

Signed-off-by: Daniel Danzberger <daniel at dd-wrt.com>
---
 block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index f094216..c6d93d1 100644
--- a/block.c
+++ b/block.c
@@ -1021,7 +1021,7 @@ static int mount_device(struct probe_info *pr, int type)
 
 	mp = find_mount_point(pr->dev);
 	if (mp) {
-		if (m && m->type == TYPE_MOUNT && strcmp(m->target, mp)) {
+		if (m && m->type == TYPE_MOUNT && m->target && strcmp(m->target, mp)) {
 			ULOG_ERR("%s is already mounted on %s\n", pr->dev, mp);
 			err = -1;
 		} else
-- 
2.30.2




More information about the openwrt-devel mailing list