[RFC PATCH] openssl: make the patches QUILT-friendly

Kevin 'ldir' Darbyshire-Bryant ldir at darbyshire-bryant.me.uk
Fri Mar 26 22:35:26 GMT 2021



> On 26 Mar 2021, at 18:55, Eneas U de Queiroz <cotequeiroz at gmail.com> wrote:
> 
> The patches in this package are all made by git format-patches.  If one
> were to run 'make package/openssl/{refresh,update}', then things will
> not work as expected, because quilt QUILT does not deal well with
> patches that rename files.  For openssl, the problematic patch is
> 430-e_devcrypto-make-the-dev-crypto-engine-dynamic.patch.
> 
> So, I've generated a new patch with 'git format-patch --no-renames', and
> then 'make package/openssl/{refresh,update}'.
> 
> Signed-off-by: Eneas U de Queiroz <cotequeiroz at gmail.com>
> ---
> 
> While I really prefer to leave the git-formatted patches as they are, I
> know quilt is the preferred way of handling patches in OpenWRT, so I'm
> presenting this as RFC, so the core developers can decide.
> 
> ldir has made a similar commit e27ef2da0d, and then reverted it right away
> in bbb9c1c2be, and I don't know why.
<snip>

I was trying to do my own 1.1.1k bump which ended badly.  I was also frustrated that there was patch fuzz in the tree on a fairly core package - that really shouldn’t be the case.  So I resolved to fix that and push it before understanding the full implications of the file rename stuff going on.  I reverted on the basis I was in far too deep.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210326/7b2646c5/attachment.sig>


More information about the openwrt-devel mailing list