[PATCH] ubusd: convert tx_queue to linked list

Arnout Vandecappelle arnout at mind.be
Thu Mar 25 20:49:37 GMT 2021



On 25/03/2021 10:09, Sergey Zakharchenko wrote:
> Hi Arnout,
> 
> JFYI: Much of your patch resembles
> https://patchwork.ozlabs.org/project/lede/patch/20180503100622.11168-1-i@qbox.audio/
> which was marked superseded for no apparent reason, but "anonymous
> remembers":).

 It's delegated to John, so maybe he intended to rework and apply it but never
got around to it.


> As for the limits, one of them could include a timeout (e.g. no
> progress in writing to client for over 10s => ubusd closes
> connection).

 Oh yes, just what we need, more complexity :-)

 I agree though that timeout on Tx would make sense. It doesn't help for DoS
attacks, but it does help to protect against a frozen client.

 Regards,
 Arnout




More information about the openwrt-devel mailing list