[PATCH] gmp: compile with -DPIC to use correct asm code

Eneas U de Queiroz cotequeiroz at gmail.com
Fri Mar 19 22:06:15 GMT 2021


On Fri, Mar 19, 2021 at 5:08 PM Philip Prindeville
<philipp_subx at redfish-solutions.com> wrote:
>
>
> Maybe I'm missing something, but why not just fix rules.mk:
>
>
> ifneq (,$(findstring $(ARCH) , aarch64 aarch64_be powerpc ))
>   FPIC:=-fPIC
> else
>   FPIC:=-fpic
> endif
>
> HOST_FPIC:=-fPIC
>
>
> To have the FPIC and HOST_FPIC definitions include -DPIC?

I think it would be the proper way to handle this.  I was initially
fearful of changing too much and breaking things, but I think it
should be expected behaviour.  What else would you use a 'PIC'
definition for?  I will resend a patch changing rules.mk instead.



More information about the openwrt-devel mailing list