[PATCH v2 2/6] realtek: need to handle PHY_INTERFACE_MODE_NA for sfps

Bjørn Mork bjorn at mork.no
Sat Mar 13 16:45:50 GMT 2021


>From the validate docs in include/linux/phylink.h:

 When state->interface is PHY_INTERFACE_MODE_NA, phylink expects the
 MAC driver to return all supported link modes.

Tested-by: Birger Koblitz <mail at birger-koblitz.de>
Signed-off-by: Bjørn Mork <bjorn at mork.no>
---
 target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c b/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
index af6d92cbc221..2c49ea27a167 100644
--- a/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
+++ b/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
@@ -245,6 +245,7 @@ static void rtl83xx_phylink_validate(struct dsa_switch *ds, int port,
 	pr_debug("In %s port %d", __func__, port);
 
 	if (!phy_interface_mode_is_rgmii(state->interface) &&
+	    state->interface != PHY_INTERFACE_MODE_NA &&
 	    state->interface != PHY_INTERFACE_MODE_1000BASEX &&
 	    state->interface != PHY_INTERFACE_MODE_MII &&
 	    state->interface != PHY_INTERFACE_MODE_REVMII &&
-- 
2.20.1




More information about the openwrt-devel mailing list