[PATCH] realtek: drop ethtool log noise

Bjørn Mork bjorn at mork.no
Wed Mar 10 19:09:20 GMT 2021


phylink_mac_link_state calls can be triggered by userspace, and
might happen rather often in some settings like when running snmp
daemons.

Signed-off-by: Bjørn Mork <bjorn at mork.no>
---
One more patch I forgot I've been using.

This log line is pretty annoying in combination with mini_snmpd
with ethtool support (coming soon - waiting for next mini_snmpd
release).   I get a useless log line every second:

root at gs1900-10hp:~# dmesg|tail
[81531.616961] rtl83xx_phylink_mac_link_state: link state: 4000000
[81532.664304] rtl83xx_phylink_mac_link_state: link state: 4000000
[81533.708279] rtl83xx_phylink_mac_link_state: link state: 4000000
[81534.752309] rtl83xx_phylink_mac_link_state: link state: 4000000
[81535.796137] rtl83xx_phylink_mac_link_state: link state: 4000000
[81536.840221] rtl83xx_phylink_mac_link_state: link state: 4000000
[81537.884238] rtl83xx_phylink_mac_link_state: link state: 4000000
[81538.928239] rtl83xx_phylink_mac_link_state: link state: 4000000
[81539.972367] rtl83xx_phylink_mac_link_state: link state: 4000000
[81541.016272] rtl83xx_phylink_mac_link_state: link state: 4000000

 target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c b/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
index f7b9aca7a7c0..987b47dc8fc6 100644
--- a/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
+++ b/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
@@ -311,7 +311,7 @@ static int rtl83xx_phylink_mac_link_state(struct dsa_switch *ds, int port,
 	link = priv->r->get_port_reg_le(priv->r->mac_link_sts);
 	if (link & BIT_ULL(port))
 		state->link = 1;
-	pr_info("%s: link state: %llx\n", __func__, link & BIT_ULL(port));
+	pr_debug("%s: link state: %llx\n", __func__, link & BIT_ULL(port));
 
 	state->duplex = 0;
 	if (priv->r->get_port_reg_le(priv->r->mac_link_dup_sts) & BIT_ULL(port))
-- 
2.20.1




More information about the openwrt-devel mailing list