[PATCH] base-files: sysupgrade: store status of system-services

Reiner Karlsberg karlsberg at softart-ge.com
Sat Jan 9 06:56:13 EST 2021


Am 09.01.2021 um 13:28 schrieb Stijn Segers:

 > Currently all services get enabled during image creation. This can cause
 > issues after upgrade with services explicitly disabled by the user.
 > With this created list sourced by a simple uci-defaults script the state
 > can be restored automatically.

Pls, do _NOT_ make this default.
There might be other entities, besides me, who already have
implemented methods to work around unnecessary enabled services.
I.e. to disable service in uci-defaults, like I do.
Auto-restore service state will break existing code.

In general, I do _NOT_ consider it a good idea, to more or less
silently modify existing functionality.
Which happems often enough in openwrt, unfortunately.

Best would be, to make this new behaviour optional. Do another change for LuCI, and then this is done.

In worst case, pls provide an option for sysupgrade _NOT_
to keep service state.

Cheers,

Reiner




More information about the openwrt-devel mailing list