[PATCH v5 2/2] realtek: add support for ZyXEL GS1900-8HP v1 and v2

Bjørn Mork bjorn at mork.no
Sat Jan 9 06:35:47 EST 2021


"Adrian Schmutzler" <mail at adrianschmutzler.de> writes:

> Feel free to submit new patches for the remaining stuff if you desire.

One simple thing to fix for the GS1900-xxx is the ability to upgrade to
OpenWrt from the stock web UI, without using the console at all.

But this requires changing to the device specific magic, since the stock
web UI verifies this before accepting an image.  It would be good to
know where to move with the u-image mtdsplitter before submitting more
of those patches.  Should I prepare a minimalistic new splitter using DT
and leave the existing ones as is?  Or should we just continue like
before, constantly adding new magic numbers to the code?

Note that there hopefully will be a large number of vendors and devices
supported by the realtek target. The potentional is almost unlimited,
with a whole new 10gig and multigig generation (RTL93xx) being within
reach.  And the Realtek SDK has made most (all) vendors use some
non-standard magic. So we might end up with a lot of churn and new
entries in the u-image splitter, bloating it for everyone. Fine with me
if that's what you want. But if you don't, then that decision should be
made now.


Bjørn



More information about the openwrt-devel mailing list