[PATCH v2] fakeroot: fix to work with glibc 2.33
philipp_subx at redfish-solutions.com
Sat Feb 13 21:39:31 EST 2021
> On Feb 12, 2021, at 10:52 AM, Ilya Lipnitskiy <ilya.lipnitskiy at gmail.com> wrote:
> Hi Philip,
> On Thu, Feb 11, 2021 at 11:23 PM Philip Prindeville
> <philipp_subx at redfish-solutions.com> wrote:
>> Minor nit, but please combine these into a single line:
>> Please indent nested #if or #ifdef's.
> I can make the style changes, but a couple of points to consider:
> 1. These changes have already been submitted upstream;
> 2. If you look elsewhere within libfakeroot.c it is peppered with
> #ifdefs that are not indented or combined, so I mostly followed the
> existing code style (or the absence thereof)
> : https://salsa.debian.org/clint/fakeroot/-/merge_requests/8
If it's already been submitted and accepted, then leave it.
If they ask you to resubmit with changes, add that too please.
More information about the openwrt-devel