[PATCH v2 3/3] scripts,ipkg-build: format code with shfmt

Paul Oranje por at oranjevos.nl
Tue Feb 9 07:36:27 EST 2021

Op 5 feb. 2021, om 00:59 heeft Paul Spooren <mail at aparcar.org> het volgende geschreven:
> The script improves readability by using an automatic code formatter.

The decreases of the switch case indentation levels make sense, but IMHO the removals of the space between redirection and source (e.g. <prog i.s.o. < prog) do not add to the readability, and to a lesser degree, nor does placing an empty or small command on the same line as the case (e.g. case x) ;;).

Maybe your preferred code formatter/beautifier (which ?) could take some options to steer the formatting. Would you agree?

Thanks anyway, bye,

More information about the openwrt-devel mailing list