[PATCH] prereq-build: require python3-distutils

[Hauke Mehrtens]

Hi Andre,

I pushed this to 21.02 now.

Hauke

On 8/24/21 12:21 AM, Andre Heider wrote:
> Nice, sounds good, thanks!
> 
> On 23/08/2021 23:12, Hauke Mehrtens wrote:
>> Hi Andre,
>>
>> I will backport this to 21.02 in the next days. I want to wait if 
>> there are more problems showing up in master.
>>
>> Hauke
>>
>> On 8/23/21 10:47 PM, Andre Heider wrote:
>>> Hi Hauke,
>>>
>>> thanks for merging the patch!
>>>
>>> Can we also get this cherry-picked to the 21.02 branch, please?
>>>
>>> Jeffery makes some good points as to why here:
>>> https://github.com/openwrt/packages/pull/16304#issuecomment-904097018
>>>
>>> I too can see that package backports could get unnecessarily painful 
>>> in the future without this in 21.02.
>>>
>>> Thanks,
>>> Andre
>>>
>>> On 10/08/2021 12:22, Andre Heider wrote:
>>>> Debian and Ubuntu ship a python3-minimal package which does not include
>>>> the distutils module. This is not supported by upstream and can be
>>>> considered a broken python distribution.
>>>>
>>>> In practice, many scripts depend on said module, and this is a 
>>>> reoccuring
>>>> pain point for building various OpenWrt packages.
>>>>
>>>> Require and check for said module, enough time has been wasted on this.
>>>>
>>>> A list of just the most recent issues:
>>>> https://github.com/openwrt/packages/pull/16304
>>>> https://github.com/openwrt/packages/pull/16027
>>>> https://github.com/openwrt/packages/pull/15443
>>>> https://github.com/openwrt/packages/pull/14394
>>>> https://github.com/openwrt/packages/pull/12909
>>>> https://github.com/openwrt/packages/issues/12443
>>>> https://github.com/openwrt/packages/pull/11035
>>>> https://github.com/openwrt/packages/issues/10993
>>>>
>>>> Signed-off-by: Andre Heider <a.heider at gmail.com>
>>>> ---
>>>>   include/prereq-build.mk | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/include/prereq-build.mk b/include/prereq-build.mk
>>>> index 8fbf6f22c4..922e7c544b 100644
>>>> --- a/include/prereq-build.mk
>>>> +++ b/include/prereq-build.mk
>>>> @@ -170,6 +170,10 @@ $(eval $(call SetupHostCommand,python3,Please 
>>>> install Python >= 3.6, \
>>>>       python3.6 -V 2>&1 | grep 'Python 3', \
>>>>       python3 -V 2>&1 | grep -E 'Python 3\.[6-9]\.?'))
>>>> +$(eval $(call TestHostCommand,python3-distutils, \
>>>> +    Please install the Python3 distutils module, \
>>>> +    $(STAGING_DIR_HOST)/bin/python3 -c 'import distutils'))
>>>> +
>>>>   $(eval $(call SetupHostCommand,git,Please install Git (git-core) 
>>>> >= 1.7.12.2, \
>>>>       git --exec-path | xargs -I % -- grep -q -- --recursive 
>>>> %/git-submodule))
>>>>
>>>
>>
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x93DD20630910B515.asc
Type: application/pgp-keys
Size: 13571 bytes
Desc: OpenPGP public key
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210829/60ca9d8f/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210829/60ca9d8f/attachment-0001.sig>