[PATCH 6/8] at91: enable specific sam9x kernel config flags

[Claudiu.Beznea at microchip.com]

On 22.08.2021 15:02, Hauke Mehrtens wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> 
> ForwardedMessage.eml
> 
> Subject:
> Re: [PATCH 6/8] at91: enable specific sam9x kernel config flags
> From:
> Hauke Mehrtens <hauke at hauke-m.de>
> Date:
> 22.08.2021, 15:02
> 
> To:
> Claudiu Beznea <claudiu.beznea at microchip.com>, openwrt-devel at lists.openwrt.org
> 
> 
> On 8/20/21 1:42 PM, Claudiu Beznea wrote:
>> Enable specific sam9x kernel config flags.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea at microchip.com>
>> ---
>>   target/linux/at91/sam9x/config-default | 182 ++++++++++++++++++++++++-
>>   1 file changed, 176 insertions(+), 6 deletions(-)
>>
>> diff --git a/target/linux/at91/sam9x/config-default
>> b/target/linux/at91/sam9x/config-default
>> index d8b5c31dc7e5..0b8e8947ee12 100644
>> --- a/target/linux/at91/sam9x/config-default
>> +++ b/target/linux/at91/sam9x/config-default
>> @@ -20,7 +20,7 @@ CONFIG_ARM_PATCH_PHYS_VIRT=y
> ....
>> +CONFIG_INPUT=y
>> +CONFIG_INPUT_KEYBOARD=y
>> +CONFIG_IPV6=y
>> +# CONFIG_IPV6_SEG6_LWTUNNEL is not set
> 
> IPv6 should not be activated in the target configuration, but it is
> globally controlled by CONFIG_KERNEL_IPV6.
> 
> ....
>>   CONFIG_NEED_DMA_MAP_STATE=y
>>   CONFIG_NEED_KUSER_HELPERS=y
>>   CONFIG_NEED_PER_CPU_KM=y
>> +CONFIG_NFS_FS=y
> 
> Is NFS really needed build into the kernel?

No.

> 
>> +CONFIG_NLS=y
>> +CONFIG_NVMEM=y
>> +CONFIG_NVMEM_SYSFS=y
>>   CONFIG_OF=y
>>   CONFIG_OF_ADDRESS=y
>>   CONFIG_OF_EARLY_FLATTREE=y
>> @@ -130,40 +201,139 @@ CONFIG_OF_FLATTREE=y
>>   CONFIG_OF_GPIO=y
>>   CONFIG_OF_IRQ=y
>>   CONFIG_OF_KOBJ=y
>> +CONFIG_OF_MDIO=y
>>   CONFIG_OF_NET=y
>>   CONFIG_OLD_SIGACTION=y
>>   CONFIG_OLD_SIGSUSPEND3=y
>>   CONFIG_PAGE_OFFSET=0xC0000000
>>   CONFIG_PERF_USE_VMALLOC=y
>>   CONFIG_PGTABLE_LEVELS=2
>> +CONFIG_PHYLIB=y
>>   CONFIG_PINCTRL=y
>>   CONFIG_PINCTRL_AT91=y
>>   # CONFIG_PINCTRL_AT91PIO4 is not set
>> +CONFIG_POWER_RESET=y
>> +CONFIG_POWER_RESET_AT91_POWEROFF=y
>> +CONFIG_POWER_RESET_AT91_RESET=y
>> +# CONFIG_POWER_RESET_AT91_SAMA5D2_SHDWC is not set
>> +CONFIG_POWER_SUPPLY=y
>> +CONFIG_PPP=m
> 
> PPP is added with a kmod package.
> Selecting anything as =m does not make sense as the module would only be
> build and not packaged into the image without the OpenWrt kmod package
> being selected too.
> 
> The target configuration should only contain the minimal kernel options
> which are needed for this target. This includes options which are needed to
> boot up the system and options for driver which are used on most boards
> like an IP core of the SoC which is used by many boards.

Sure! I wasn't aware of this rule. I synced-up the entire config with what
there is currently on kernel vendor tree when I discovered that AT91_*
specific SoCs flags are not enabled and target is not booting.

> 
>> +CONFIG_PPPOE=m
>> +CONFIG_PPP_ASYNC=m
> ...
>> +CONFIG_SCSI=y
> 
> Is SCSI really needed?

Same here, no!
> 
> Hauke