[PATCH v2] imagebuilder, sdk: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archives

[Sven Roederer]

Adrian,

Am Sonntag, 25. April 2021, 21:09:40 CEST schrieb Adrian Schmutzler:
> Hi,
> 
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> > On Behalf Of Sven Roederer
> > Sent: Samstag, 24. April 2021 23:48
> > To: openwrt-devel at lists.openwrt.org
> > Subject: [PATCH v2] imagebuilder, sdk: unset BINARY_FOLDER and
> > DOWNLOAD_FOLDER in final archives
> > 
> > Using these config-options to customize the folders used at build-time
> > makes these folder settings appear in generated archives. This causes the
> > archives to be not portable, as they going to use the build-time folders
> > on
> > 
> > the new systems. Errors look like for the imagebuilder:
> >   mkdir: cannot create directory '/mnt/build': Permission denied
> >   Makefile:116: recipe for target '_call_image' failed
> >   make[2]: *** [_call_image] Error 1
> >   Makefile:241: recipe for target 'image' failed
> >   make[1]: *** [image] Error 2
> > 
> > The build-time settings of these folders are passed into the archives via
> > .config for the imagebuilder and via Config.in and Config.build for the
> > sdk. The expected behavior is that after unpacking sdk and imagebuilder
> > act like these settings have the default, using intree folders. So unset
> > or filter out the build- time settings.
> 
> Consider breaking this down into separate patches for imagebuilder and sdk.
> 

pushed a splitted version as V3 [1].
Indeed I squashed them before submitting initially :-)

Best Sven

1 - https://patchwork.ozlabs.org/project/openwrt/list/?series=240802