[PATCH] kernel: Disable CONFIG_COMPAT_32BIT_TIME by default

Rosen Penev rosenp at gmail.com
Wed Apr 14 23:49:12 BST 2021


On Wed, Apr 14, 2021 at 6:27 AM Linus Walleij <linus.walleij at linaro.org> wrote:
>
> OpenWRT rebuilds the whole userspace from scratch and uses
> recent versions of tools and libraries, thus it should not
> be necessary in general to support CONFIG_COMPAT_32BIT_TIME,
> not even for purely 32bit systems: their updated userspace
> components should be fine with only 64bit time_t.
Funny.

time_t is still 32-bit for 32-bit targets. OpenWrt has not migrated to
musl 1.2.x.

https://github.com/openwrt/openwrt/pull/3004 is a pull request to do
so but it seems nobody has looked into merging it.
>
> As OpenWRT is used as a base for embedded products for the
> future market it is the right default to set.
I agree
>
> Several targets enable this selectively, probably some of
> them should consider disabling it and see what happens.
That's an upstream issue, no?
>
> Cc: Arnd Bergmann <arnd at arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
>  target/linux/generic/config-5.10 | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target/linux/generic/config-5.10 b/target/linux/generic/config-5.10
> index 120d1d8c3f4a..024d65ba7c8d 100644
> --- a/target/linux/generic/config-5.10
> +++ b/target/linux/generic/config-5.10
> @@ -939,6 +939,7 @@ CONFIG_CMDLINE=""
>  CONFIG_COMPACTION=y
>  # CONFIG_COMPAL_LAPTOP is not set
>  # CONFIG_COMPAT is not set
> +# CONFIG_COMPAT_32BIT_TIME is not set
>  # CONFIG_COMPAT_BRK is not set
>  # CONFIG_COMPILE_TEST is not set
>  # CONFIG_CONFIGFS_FS is not set
> --
> 2.29.2
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list