firmware-utils: mkmylofw broken since 9. Apr 2021

Sven Roederer devel-sven at geroedel.de
Tue Apr 13 22:32:15 BST 2021


Hi Rafał,

thanks for picking this up soo quickly.

Am Dienstag, 13. April 2021, 14:02:10 CEST schrieb Rafał Miłecki:
> > The original code comes from Florian from the 2007 commit 7b564bfdcbef
> > ("Fix potential unligned access with MyLoader based devices, thanks
> > Juhos")
> > 
> > https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=7b564bfdcbef
> > 05f68d8a658caf832c6832705e1f
> > 
> > Sven, Florian: any chance you know how that code:
> > /* align next block on a 4 byte boundary */
> > len = ALIGN(len,4) - block->size;
> > 
> > was meant to behave originally?
> 
> Please check commit d4f2c2914a65 ("firmware-utils: mkmylofw: fix blocks
> padding")
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=d4f2c2914a6547
> ef6067dd0968c4970e913f17f0

I can confirm, that this change make the image-building pass with filesizes as 
expected. 
As I don't own any of this hardware, I can't do run-test but only compile 
test.

Best Sven





More information about the openwrt-devel mailing list