[PATCH v5 1/1] ltq-vdsl-app: extent dsl metrics with state_num and power_state_num

[Andre Heider]

On 13/04/2021 08:28, Florian Eckert wrote:
>>>   +/* These values are exported via ubus and backwards compability
>>> + * needs to be kept!
>>> + */
>>> +enum {
>>> +    LSTATE_MAP_UNKNOWN = 0,
>>> +    LSTATE_MAP_EXCEPTION,
>>> +    LSTATE_MAP_IDLE,
>>> +    LSTATE_MAP_SILENT,
>>> +    LSTATE_MAP_HANDSHAKE,
>>> +    LSTATE_MAP_FULL_INIT,
>>> +    LSTATE_MAP_SHOWTIME_NO_SYNC,
>>> +    LSTATE_MAP_SHOWTIME_TC_SYNC,
>>> +    LSTATE_MAP_RESYNC,
>>> +    LSTATE_MAP_NOT_INITIALIZED,
>>
>> Except for the last entry, the order matches lantiq's DSL_LineState_t.
>> Doesn't really matter as long as we don't change these values, but was
>> there a reason for that?
> 
> No there is no particular reason for that.
> Should I then send a v6?
> Where this value then comes after LSTATE_MAP_UNKNOWN?

I don't care too much either way, but if you do you might as well set 
LSTATE_MAP_UNKNOWN to -1, so the exported values start at 0.