[RFC PATCH] ath79: remove model name from LED labels

[Adrian Schmutzler]

Hi Henrique,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Henrique de Moraes Holschuh
> Sent: Mittwoch, 30. September 2020 16:47
> To: openwrt-devel at lists.openwrt.org
> Subject: Re: [RFC PATCH] ath79: remove model name from LED labels
> 
> On 30/09/2020 09:49, Adrian Schmutzler wrote:
> > While we cannot use the upstream approach at the moment as it's not
> ready, the removal of devicename seems a good step for now, and as I
> understand it it's still a step into the right direction.
> 
> As an user and downstream maintainer, I'd only ask that config migration
> scripts are provided where applicable.

Migration is currently planned like this:

https://github.com/openwrt/openwrt/pull/3464/commits/a5e71ead5744e40d73f8ca9370a569d5e0998fed

(Not tested yet.)

The idea is essentially to look for uci LED sysfs entries (/etc/config/system) with two colons, and if those are found, the part before the first colon is removed, e.g.

dir-789:green:status -> green:status

This unconditional measure should work nicely for targets like ath79. However, it will make it impossible to intentionally add a devicename unless an exception is created. On other targets where we will have upstream devices mixed with locally managed ones, the migration will have to be triggered based on the board name.
On mixed targets, we could also consider to just use the policy on new devices and don't touch the old etc.

If somebody has a better idea or if there is another location that stores the LED names I didn't think of, please tell me.

Best

Adrian

> 
> With that caveat sorted, looks like an overall win to me.
> 
> --
> Henrique de Moraes Holschuh
> Analista de Projetos
> Centro de Estudos e Pesquisas em Tecnologias de Redes e Operações
> (Ceptro.br)
> +55 11 5509-3537 R.:4023
> INOC 22548*625
> www.nic.br
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200930/f9524772/attachment.sig>