[RFC PATCH] ath79: remove model name from LED labels

[Piotr Dymacz]

Hi Felix, Adrian,

On 30.09.2020 13:53, Felix Fietkau wrote:
> 
> On 2020-09-30 13:43, Adrian Schmutzler wrote:
>>> -----Original Message-----
>>> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
>>> On Behalf Of Adrian Schmutzler
>>> Sent: Sonntag, 27. September 2020 23:55
>>> To: openwrt-devel at lists.openwrt.org
>>> Subject: RE: [RFC PATCH] ath79: remove model name from LED labels
>> 
>> Hi all,
>> 
>> since there doesn't seem to be any interest in the subject initially, I'd also be interested if there are any general objections towards dropping "devicename" and using "color:function" scheme on LEDs.
>> 
>> I'd actually be quite happy to get rid of this obstacle that annoyed me consistently throughout my involvement with OpenWrt.
> The devicename in the LEDs has also annoyed me often enough. No idea why
> it was added in the first place.

It comes from upstream (2006-2008):

https://github.com/torvalds/linux/commit/75c1d31d9ea71025b73430c696b727e8aa15872d

https://github.com/torvalds/linux/commit/6c152beefbf90579d21afc4f7e075b1f801f9a75

> I think getting rid of it is a really good idea.

It doesn't bring us closer to the current upstream approach (functions 
and colors IDs) but should make things easier for contributors and 
reviewers.

-- 
Cheers,
Piotr

> 
> - Felix
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>