[PATCH 2/2] target/linux: disable legacy and debug cifs options

Hauke Mehrtens hauke at hauke-m.de
Sat Oct 10 17:03:58 EDT 2020


On 9/15/20 3:33 AM, Rosen Penev wrote:
> CIFS_ALLOW_INSECURE_LEGACY is only relevant for mounting shares that
> are provided by old CIFS servers. It is not relevant to the Samba or
> ksmbd package that provide a server.

There are many old SMB servers running which do not support SMB 2.1 or 
later. By looking at the code it does not look like we save much space 
by deactivating CONFIG_CIFS_ALLOW_INSECURE_LEGACY. I would prefer to kee 
CONFIG_CIFS_ALLOW_INSECURE_LEGACY activated.


> CIFS_STATS is a debugging option. It is not really useful for end users
> 
> Signed-off-by: Rosen Penev <rosenp at gmail.com>
> ---
>   target/linux/generic/config-4.19 | 4 ++--
>   target/linux/generic/config-5.4  | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/target/linux/generic/config-4.19 b/target/linux/generic/config-4.19
> index d4a942f9aa..e9c6306307 100644
> --- a/target/linux/generic/config-4.19
> +++ b/target/linux/generic/config-4.19
> @@ -776,14 +776,14 @@ CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y
>   # CONFIG_CICADA_PHY is not set
>   # CONFIG_CIFS is not set
>   # CONFIG_CIFS_ACL is not set
> -CONFIG_CIFS_ALLOW_INSECURE_LEGACY=y
> +# CONFIG_CIFS_ALLOW_INSECURE_LEGACY is not set
>   # CONFIG_CIFS_DEBUG is not set
>   # CONFIG_CIFS_DEBUG2 is not set



More information about the openwrt-devel mailing list