[OpenWrt-Devel] linux5.4: build-dependency to rsync

[Sven Roederer]

Am Sonntag, 19. April 2020, 11:32:03 CEST schrieb Bjørn Mork:
> Sven Roederer <devel-sven at geroedel.de> writes:
> > I was just building a master-branch for x86-generic and got following
> > error:
> > 
> > make[5]: Entering directory '/mnt/local/btrfs/build/freifunk/ffberlin/
> > firmware/openwrt/build_dir/toolchain-i386_pentium4_gcc-8.4.0_musl/
> > linux-5.4.28'
> > 
> >   INSTALL
> >   /mnt/local/btrfs/build/freifunk/ffberlin/firmware/openwrt/build_dir/> 
> > toolchain-i386_pentium4_gcc-8.4.0_musl/linux-dev//include
> > /bin/sh: 1: rsync: not found
> > make[5]: *** [Makefile:1186: headers_install] Error 127
> > make[5]: Leaving directory
> > '/mnt/local/btrfs/build/freifunk/ffberlin/firmware/
> > openwrt/build_dir/toolchain-i386_pentium4_gcc-8.4.0_musl/linux-5.4.28'
> > make[4]: *** [Makefile:108:
> > /mnt/local/btrfs/build/freifunk/ffberlin/firmware/
> > openwrt/build_dir/toolchain-i386_pentium4_gcc-8.4.0_musl/
> > linux-5.4.28/.configured] Error 2
> > make[4]: Leaving directory
> > '/mnt/local/btrfs/build/freifunk/ffberlin/firmware/
> > openwrt/toolchain/kernel-headers'
> > time: toolchain/kernel-headers/compile#1.46#0.83#2.26
> > 
> > 
> > In https://github.com/torvalds/linux/commit/59b2bd05f5f4d the call to
> > rsync
> > was added. I think we have the 2 options:
> > * use host-command (changing the build-requirements)
> > * compile it ourself (like we do with zip: ad8c2d6099a7da51)
> 
> This new dependency looks like it might have been unintentional.  rsync
> is not documented in Documentation/process/changes.rst . And there must
> be many other recursive file copying rules in the kernel build system,
> which do *not* depend on rsync.
> 
> Maybe check with the kernel community first, verifying that this new
> build dependency was in fact intended?  At the very least, that should
> result in a patch to Documentation/process/changes.rst making this
> explicit.
> 
As neoraider mentioned on github [1] is doesn't look unintended, also the PR 
[2] seems to be welcome.

Sven

1 - https://github.com/freifunk-gluon/gluon/commit/
0d616ff2d4cd0a78410ccd993eebdc12d9ecf97f#commitcomment-42864694
2 - https://marc.info/?l=linux-doc&m=160159054823006&w=2