[PATCH] ath79: remove num-chipselects from SPI controller

Adrian Schmutzler freifunk at adrianschmutzler.de
Sun Nov 29 11:07:17 EST 2020


The num-chipselects property is only valid for bit-banged spi-gpio [1].

For the generic SPI controller bindings, num-cs would be the correct
property [2].

Since the value does not seem to be required anyway, though, let's
just remove it.

[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/spi/spi-gpio.yaml
[2] https://www.kernel.org/doc/Documentation/devicetree/bindings/spi/spi-controller.yaml

Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
---
 target/linux/ath79/dts/ar9330_dlink_dir-505.dts          | 1 -
 target/linux/ath79/dts/ar9330_glinet_gl-ar150.dts        | 2 --
 target/linux/ath79/dts/ar9331_8dev_carambola2.dts        | 1 -
 target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts | 2 --
 target/linux/ath79/dts/ar9331_etactica_eg200.dts         | 1 -
 target/linux/ath79/dts/ar9331_glinet_gl-mifi.dts         | 2 --
 target/linux/ath79/dts/ar9331_tplink_tl-mr3020-v1.dts    | 2 --
 target/linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dts    | 2 --
 target/linux/ath79/dts/ar9344_zbtlink_zbt-wd323.dts      | 1 -
 9 files changed, 14 deletions(-)

diff --git a/target/linux/ath79/dts/ar9330_dlink_dir-505.dts b/target/linux/ath79/dts/ar9330_dlink_dir-505.dts
index 15e29f552e..574165b748 100644
--- a/target/linux/ath79/dts/ar9330_dlink_dir-505.dts
+++ b/target/linux/ath79/dts/ar9330_dlink_dir-505.dts
@@ -88,7 +88,6 @@
 };
 
 &spi {
-	num-chipselects = <1>;
 	status = "okay";
 
 	flash at 0 {
diff --git a/target/linux/ath79/dts/ar9330_glinet_gl-ar150.dts b/target/linux/ath79/dts/ar9330_glinet_gl-ar150.dts
index 26b3b3f04c..20c9a8fdd4 100644
--- a/target/linux/ath79/dts/ar9330_glinet_gl-ar150.dts
+++ b/target/linux/ath79/dts/ar9330_glinet_gl-ar150.dts
@@ -79,8 +79,6 @@
 &spi {
 	status = "okay";
 
-	num-chipselects = <1>;
-
 	flash at 0 {
 		compatible = "jedec,spi-nor";
 		spi-max-frequency = <50000000>;
diff --git a/target/linux/ath79/dts/ar9331_8dev_carambola2.dts b/target/linux/ath79/dts/ar9331_8dev_carambola2.dts
index 85e70495fc..42193f857c 100644
--- a/target/linux/ath79/dts/ar9331_8dev_carambola2.dts
+++ b/target/linux/ath79/dts/ar9331_8dev_carambola2.dts
@@ -63,7 +63,6 @@
 };
 
 &spi {
-	num-chipselects = <0>;
 	status = "okay";
 
 	flash at 0 {
diff --git a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
index 9303121408..12f1e93d44 100644
--- a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
+++ b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
@@ -59,8 +59,6 @@
 &spi {
 	status = "okay";
 
-	num-chipselects = <1>;
-
 	flash at 0 {
 		compatible = "jedec,spi-nor";
 		spi-max-frequency = <50000000>;
diff --git a/target/linux/ath79/dts/ar9331_etactica_eg200.dts b/target/linux/ath79/dts/ar9331_etactica_eg200.dts
index 0d7b7cfb84..e6feb54fcd 100644
--- a/target/linux/ath79/dts/ar9331_etactica_eg200.dts
+++ b/target/linux/ath79/dts/ar9331_etactica_eg200.dts
@@ -83,7 +83,6 @@
 };
 
 &spi {
-	num-chipselects = <1>;
 	status = "okay";
 
 	flash at 0 {
diff --git a/target/linux/ath79/dts/ar9331_glinet_gl-mifi.dts b/target/linux/ath79/dts/ar9331_glinet_gl-mifi.dts
index d62bdd9d67..67b587ab6e 100644
--- a/target/linux/ath79/dts/ar9331_glinet_gl-mifi.dts
+++ b/target/linux/ath79/dts/ar9331_glinet_gl-mifi.dts
@@ -87,8 +87,6 @@
 &spi {
 	status = "okay";
 
-	num-chipselects = <1>;
-
 	flash at 0 {
 		compatible = "jedec,spi-nor";
 		spi-max-frequency = <33000000>;
diff --git a/target/linux/ath79/dts/ar9331_tplink_tl-mr3020-v1.dts b/target/linux/ath79/dts/ar9331_tplink_tl-mr3020-v1.dts
index 7c52ae1617..e9533553a1 100644
--- a/target/linux/ath79/dts/ar9331_tplink_tl-mr3020-v1.dts
+++ b/target/linux/ath79/dts/ar9331_tplink_tl-mr3020-v1.dts
@@ -110,8 +110,6 @@
 &spi {
 	status = "okay";
 
-	num-chipselects = <1>;
-
 	/* Spansion S25FL032PIF SPI flash */
 	flash at 0 {
 		compatible = "jedec,spi-nor";
diff --git a/target/linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dts b/target/linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dts
index da04aad6cb..c5f7a4fe76 100644
--- a/target/linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dts
+++ b/target/linux/ath79/dts/ar9331_tplink_tl-mr3040-v2.dts
@@ -106,8 +106,6 @@
 &spi {
 	status = "okay";
 
-	num-chipselects = <1>;
-
 	flash at 0 {
 		compatible = "jedec,spi-nor";
 		spi-max-frequency = <50000000>;
diff --git a/target/linux/ath79/dts/ar9344_zbtlink_zbt-wd323.dts b/target/linux/ath79/dts/ar9344_zbtlink_zbt-wd323.dts
index f2cb35eae9..5f24bf23d6 100644
--- a/target/linux/ath79/dts/ar9344_zbtlink_zbt-wd323.dts
+++ b/target/linux/ath79/dts/ar9344_zbtlink_zbt-wd323.dts
@@ -97,7 +97,6 @@
 };
 
 &spi {
-	num-chipselects = <1>;
 	status = "okay";
 
 	flash at 0 {
-- 
2.20.1




More information about the openwrt-devel mailing list